chore(compass-web): add an interface to propagate the tab closing checks for before unload interception COMPASS-8033 #7404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cks for before unload interception
nbbeeken
reviewed
Oct 1, 2025
|
@nbbeeken An example of a tab in the "dirty" state would be if a user has an written a query/aggregation in the tab and hasn't saved. |
Anemy
approved these changes
Oct 1, 2025
Otherwise it will make it a requirement to implement something on other side during the version bump and we don't want that
|
@Anemy good point, I'll keep it to a separate PR to make sure it's not affecting / accounted for in the e2e tests |
nbbeeken
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the change that should allow us to warn users when navigating away from the data explorer route when some tabs are in "dirty" state. We can't encapsulate all this logic inside Compass because we will have to interface with react-router on the mms side for this to work, so instead of this, we'll allow mms to get a reference to the callback that the code there will be able to run to do the check. Property name is a bit weird, but I couldn't come up with something better, suggestions are welcome